Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update sbt-buildinfo from 0.7.0 to 0.11.0 #1861

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

bloopoid
Copy link
Collaborator

Updates com.eed3si9n:sbt-buildinfo from 0.7.0 to 0.11.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.7.0).
You might want to review and update them manually.

project/build.sbt
website/yarn.lock
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-buildinfo" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.eed3si9n", artifactId = "sbt-buildinfo" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, old-version-remains, commit-count:1

bloopoid and others added 2 commits November 21, 2022 00:16
Most changes remove unused parts and the hacks to get the artifact names of published bridge jars
@tgodzik tgodzik requested review from adpi2 and ckipp01 November 21, 2022 20:21
nailgunClientLocation,
"zincVersion" -> Dependencies.zincVersion,
"bspVersion" -> Dependencies.bspVersion,
"nativeBridge04" -> (nativeBridge04Name + "_" + Keys.scalaBinaryVersion.value),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we would calculate the artifact name using sbt, but this started to cause cycles when trying to make it work under new buildinfo. Instead I decided to remove everything that is not used and just figure out the artifact name using a small heuristic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I would have thought there was a Key that could give this to you, but I can't see one either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I couldn't find it either, so decided on a heuristic

@@ -707,29 +721,31 @@ val docs = project
}
)

val jsBridge06Name = "bloop-js-bridge-0-6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name was actually bloop-js-bridge-0.6, but the . would get translated to -

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removing code 👍🏼

@tgodzik tgodzik merged commit 341800e into main Nov 22, 2022
@tgodzik tgodzik deleted the update/sbt-buildinfo-0.11.0 branch November 22, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants