chore: Remove java-debug and ignore updates for nailgun, release-early #1864
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arly javaDebug is brought in by scala-debug-adapter, so no need to define it here. Nailgun version should fixed, since it's the one Bloop works with (dropping the fork would be awesome.) Release-early should be replaced by sbt-ci-release so don't want to change the version and risk regression. Especially since it's not actively maintained.
ckipp01
approved these changes
Nov 21, 2022
| @@ -1,5 +1,7 @@ | |||
| updates.ignore = [ | |||
| { groupId = "com.github.plokhotnyuk.jsoniter-scala" }, | |||
| { groupId = "ch.epfl.scala", artifactId = "nailgun-server" }, | |||
There was a problem hiding this comment.
For some reason I always thought Bloop was using https://github.com/jvican/snailgun not yet another fork of nailgun. I'm curious how much changed in that fork and if the migration off it would be easy.
There was a problem hiding this comment.
I need to investigate what's the best solution here, especially that the Bloop fork is also using snailgun I think.
There was a problem hiding this comment.
Actually it does use snailgun 🤔
| @@ -1,5 +1,7 @@ | |||
| updates.ignore = [ | |||
| { groupId = "com.github.plokhotnyuk.jsoniter-scala" }, | |||
| { groupId = "ch.epfl.scala", artifactId = "nailgun-server" }, | |||
| { groupId = "ch.epfl.scala", artifactId = "sbt-release-early" } | |||
There was a problem hiding this comment.
Haha know I see where the release-early came from in the Metals commit.
adpi2
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javaDebug is brought in by scala-debug-adapter, so no need to define it here.
Nailgun version should fixed, since it's the one Bloop works with (dropping the fork would be awesome.)
Release-early should be replaced by sbt-ci-release so don't want to change the version and risk regression. Especially since it's not actively maintained.