refactor: Use the actual timeouts defined for tests in DebugServerSpec #1870
+111
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
wrong-timeout
branch
from
59f852a to
d716080
Compare
…rSpec Previously, we would always timeout after 35 seconds, because that was the timeout set in startDebugServer. Now, we forward the task up to the test and wait the amount specified in each test.
tgodzik
force-pushed
the
wrong-timeout
branch
from
d716080 to
714bd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would always timeout after 35 seconds, because that was the timeout set in startDebugServer. Now, we forward the task up to the test and wait the amount specified in each test.