improvement: Change the stamps to timewrapped ones #1871
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
time-wrap-stamps
branch
2 times, most recently
from
85c9962 to
3fd64a7
Compare
Previously we would use last modfied stamps for classfiles (aand other products) and hashes for jars. Now, we use hashes for both, but only if the modified time changed. Should help with scalameta/metals#4623
tgodzik
force-pushed
the
time-wrap-stamps
branch
from
3fd64a7 to
0d4a9d4
Compare
|
Locally run benchmark seems to produce the same timings and I am running the server one to confirm. |
Duhemm
approved these changes
Nov 24, 2022
| fromBloopHashToZincHash(ByteHasher.hashFileContents(converter.toPath(file).toFile())) | ||
| def forHash(fileRef: VirtualFileRef): Hash = { | ||
| val file = converter.toPath(fileRef).toFile() | ||
| if (file.exists()) |
There was a problem hiding this comment.
Why do we need to check if the file exists now but not before?
There was a problem hiding this comment.
We only used that for libraries, so they usually never got deleted, but if they did we would throw an exception. I now use it for classfiles, so they might be deleted more often and it's expected.
|
Performance test finished successfully. Benchmarks is based on merging with master |
2 similar comments
|
Performance test finished successfully. Benchmarks is based on merging with master |
|
Performance test finished successfully. Benchmarks is based on merging with master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would use last modfied stamps for classfiles (and other products) and hashes for jars. Now, we use hashes for both, but only if the modified time changed.
Should help with scalameta/metals#4623