Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove sbt asembly since it's no longer used #1882

Merged
merged 2 commits into from
Nov 28, 2022
Merged

chore: Remove sbt asembly since it's no longer used #1882

merged 2 commits into from
Nov 28, 2022
+1 −17

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Nov 28, 2022

No description provided.

@tgodzik tgodzik mentioned this pull request Nov 28, 2022
Closed
@tgodzik tgodzik changed the title chore: Remove sbt aseembly since it's no longer used chore: Remove sbt asembly since it's no longer used Nov 28, 2022
@tgodzik tgodzik requested review from adpi2 and Duhemm November 28, 2022 12:28
@tgodzik tgodzik marked this pull request as ready for review November 28, 2022 12:28
adpi2
adpi2 reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone remember when and why we used sbt-assembly?

@tgodzik
Copy link
Contributor Author

tgodzik commented Nov 28, 2022

Does anyone remember when and why we used sbt-assembly?

Looks like it was used for building a fat jar for benchmarks, but this is no longer the case.

@tgodzik
Merge branch 'main' into remove-assembly

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d38125e
adpi2
adpi2 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, then!

@tgodzik tgodzik merged commit d8126ad into scalacenter:main Nov 28, 2022
@tgodzik tgodzik deleted the remove-assembly branch November 28, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2

@Duhemm Duhemm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgodzik @adpi2