Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused cloneKafka stuff. #1888

Merged
merged 1 commit into from
Nov 29, 2022
Merged

refactor: remove unused cloneKafka stuff. #1888

merged 1 commit into from
Nov 29, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Nov 29, 2022

This isn't used at all and in the future if we really want to use this
we can revisit it and pull it back out. For now, all the cleanup we can
get makes thing easier to understand

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
  This isn't used at all and in the future if we really want to use this
  we can revisit it and pull it back out. For now, all the cleanup we can
  get makes thing easier to understand
@ckipp01 ckipp01 requested review from adpi2 and tgodzik November 29, 2022 12:00
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Need it in the future code is not really needed with git.

@ckipp01 ckipp01 merged commit 6d802b4 into main Nov 29, 2022
@ckipp01 ckipp01 deleted the byeKafka branch November 29, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants