Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update scala-library from 2.12.15 to 2.12.17 #1920

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

scala-center-steward[bot]
Copy link
Contributor

Updates org.scala-lang:scala-library from 2.12.15 to 2.12.17.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

@@ -51,7 +50,6 @@ final class CompilerCache(
componentProvider: ComponentProvider,
retrieveDir: AbsolutePath,
logger: Logger,
userResolvers: List[Resolver],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was always Nil

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, all of that was unused :O

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for removed code ha.

@tgodzik tgodzik force-pushed the update/scala-library-2.12.17 branch from 1988526 to 6a28750 Compare December 5, 2022 17:16
@tgodzik tgodzik requested review from adpi2 and ckipp01 December 5, 2022 18:04
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little cleanup. LGTM!

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small one that I think was missed for the semanticdb update.

@tgodzik tgodzik force-pushed the update/scala-library-2.12.17 branch from aebf1ad to 0944ede Compare December 6, 2022 15:35
@tgodzik tgodzik force-pushed the update/scala-library-2.12.17 branch from 0944ede to 7d4e785 Compare December 6, 2022 15:38
@ckipp01
Copy link
Member

ckipp01 commented Dec 7, 2022

Gave this another look over and it looks ready to rock and roll, so I'll merge.

@ckipp01 ckipp01 merged commit aed542c into main Dec 7, 2022
@ckipp01 ckipp01 deleted the update/scala-library-2.12.17 branch December 7, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants