Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert sbt-jmh update #1946

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: revert sbt-jmh update #1946

merged 1 commit into from
Dec 8, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 8, 2022

Locally I'm having issues ever since I merged in #1940. This
reverts that update and locks the version for now. After ripping
stuff out and cleaning up I'll dig further into this.

Locally I'm having issues ever since I merged in #1940. This
reverts that update and locks the version for now. After ripping
stuff out and cleaning up I'll dig further into this.
@ckipp01 ckipp01 requested review from tgodzik and adpi2 December 8, 2022 09:29
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of issues? This should only cause any kind of trouble for benchmarks 🤔

@ckipp01
Copy link
Member Author

ckipp01 commented Dec 8, 2022

What kind of issues? This should only cause any kind of trouble for benchmarks 🤔

so with this version I can't compile benchmarks.

[error] /Users/ckipp/Documents/scala-workspace/scalacenter/bloop/benchmarks/src/main/java/pl/project13/scala/jmh/extras/profiler/ForkedAsyncProfiler.java:36:1: cannot find symbol
[error]   symbol:   class Directions
[error]   location: class pl.project13.scala.jmh.extras.profiler.ForkedAsyncProfiler
[error] Directions
[error] /Users/ckipp/Documents/scala-workspace/scalacenter/bloop/benchmarks/src/main/java/pl/project13/scala/jmh/extras/profiler/ForkedAsyncProfiler.java:241:1: cannot find symbol
[error]   symbol:   class NoResult
[error]   location: class pl.project13.scala.jmh.extras.profiler.ForkedAsyncProfiler
[error] NoResult
[error] (benchmarks / Compile / compileIncremental) javac returned non-zero exit code
[error] Total time: 11 s, completed 8 Dec 2022, 16:09:35

Whereas when I revert it I have no issues.

@ckipp01 ckipp01 merged commit f1159f1 into main Dec 8, 2022
@ckipp01 ckipp01 deleted the revertJmh branch December 8, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants