Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Use the project working directory for running #1947

Merged
merged 2 commits into from
Dec 9, 2022
Merged

bugfix: Use the project working directory for running #1947

merged 2 commits into from
Dec 9, 2022
+42 −2

Conversation

lwronski
Copy link
Collaborator

@lwronski lwronski commented Dec 9, 2022

No description provided.

tgodzik and others added 2 commits December 9, 2022 10:41
@tgodzik
bugfix: Use the project directory for running

Verified

This commit was signed with the committer’s verified signature.
ijjk JJ Kasper
GPG key ID: 47B7C67C7B64BEE6
Verified
Learn about vigilant mode
514880e
@lwronski
Add integration test

Verified

This commit was signed with the committer’s verified signature.
ijjk JJ Kasper
GPG key ID: 47B7C67C7B64BEE6
Verified
Learn about vigilant mode
a9a87ef
@lwronski lwronski mentioned this pull request Dec 9, 2022
Closed
tgodzik
tgodzik approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Side note, this doesn't really change anything for other tools aside from ScalaCLI, which without this change would run mains in .scala-build directory

@tgodzik tgodzik merged commit b2f5ecd into scalacenter:main Dec 9, 2022
@tgodzik tgodzik added benchmarks Any change that affects our benchmark suite. and removed benchmarks Any change that affects our benchmark suite. labels Dec 9, 2022
@lwronski lwronski mentioned this pull request Dec 18, 2022
Merged
@kasiaMarek kasiaMarek mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lwronski @tgodzik