Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move the Maven plugin out of Bloop #1948

Merged
merged 2 commits into from
Dec 15, 2022
Merged

refactor: move the Maven plugin out of Bloop #1948

merged 2 commits into from
Dec 15, 2022
+31 −1,932

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 9, 2022 •
edited
Loading

This pr removes the Maven integration from this repo since it's been moved to its new home in https://github.com/scalacenter/bloop-maven-plugin.

There are a few different motivations for this:

  • Gets rid of the custom sbt code to publish a Maven plugin since now it's just published with Maven.
  • Simplifies this build.
  • Allows for the Maven integration to be versioned standalone.

Refs #1680

This was referenced Dec 9, 2022
Closed
Closed
@ckipp01
refactor: move the Maven plugin out of Bloop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bcc21d4 
This pr removes the Maven integration from this repo since it's been
moved to its new home in https://github.com/scalacenter/bloop-maven-plugin.

There are a few different motivations for this:

- Gets rid of the custom sbt code to publish a Maven plugin since now
  it's just published with Maven.
- Simplifies this build.
- Allows for the Maven integration to be versioned standalone.
@ckipp01 ckipp01 force-pushed the byeMaven branch 2 times, most recently from 5949424 to 8dc0b97 Compare December 10, 2022 09:35
@ckipp01 ckipp01 added integrations build maven Anything concerning Maven integration labels Dec 10, 2022
@ckipp01 ckipp01 marked this pull request as ready for review December 13, 2022 10:31
@ckipp01 ckipp01 requested review from tgodzik and adpi2 December 13, 2022 10:32
@ckipp01
Copy link
Member Author

ckipp01 commented Dec 13, 2022

Alright, this should be ready to rock and roll now. I realeased bloop-maven-plugin-RC4 in https://github.com/scalacenter/bloop-maven-plugin and also had a couple people that use Maven at work test it out to ensure it's actually working. I also sent in a PR to Metals to update this in scalameta/metals#4728. I think once we get this ripped out, the Metals PR merged, and then ensure everything is working I'll release the 2.0.0 stable.

@ckipp01 ckipp01 mentioned this pull request Dec 14, 2022
Closed
16 tasks
adpi2
adpi2 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments and a big 🎉

@ckipp01
docs: update the Maven docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b9f6da5
@ckipp01 ckipp01 merged commit 5bb37c7 into main Dec 15, 2022
@ckipp01 ckipp01 deleted the byeMaven branch December 15, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2

@tgodzik tgodzik

Assignees
No one assigned
Labels
build integrations maven Anything concerning Maven integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckipp01 @adpi2