refactor: stop shading launcher and bloopgun #1961
Merged
+2
−647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking back I can't find a reason as to why this was done, so my assumption is that this was done as a precaution. Looking through the deps they are quite minimal. Testing around with Metals using the unshaded version of launcher doesn't cause any issues. I also see that multiple apps are using bloop-rifle instead, and that's also not shaded, arguably has more deps, and isn't causing issues. If this is ok, we can get rid of the entire custom shading logic we have that really simplifies things and also allows us to no longer publish both shaded and not shaded versions of launcher and bloopgun. If we detect problems, we can easily then bring in sbt-shading.
adpi2
approved these changes
Dec 23, 2022
tgodzik
approved these changes
Dec 23, 2022
|
lol I feel like I've just been taking an 🪓 to this thing. Love it.
Exactly my thoughts as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking back I can't find a reason as to why this was done, so my
assumption is that this was done as a precaution. Looking through the
deps they are quite minimal. Testing around with Metals using the
unshaded version of launcher doesn't cause any issues. I also see that
multiple apps are using bloop-rifle instead, and that's also not shaded,
arguably has more deps, and isn't causing issues. If this is ok, we can
get rid of the entire custom shading logic we have that really
simplifies things and also allows us to no longer publish both shaded
and not shaded versions of launcher and bloopgun. If we detect problems,
we can easily then bring in sbt-shading.
There is a discussion related to this with more details in #1958.
Also note that if we want to actually slim down the deps in these, I think it's doable. For example we bring in jsoniter in bloopgun only to read the global config since it's json, and that config has two fields.