chore(deps): bump scalaz to 7.3.7 #1963
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So this isn't used very much at all, only for the Show typeclass, and that's what was breaking here due to the introduction of `Cord`. I think my little hack is fine, it' just creates the cord out of the result of the `shows` method. However, I'm not 100% sure, so let's run the tests and see. I also removed scalaz concurrent because from what I can tell, it wasn't being used and with the new version, it's not there anymore. Supersedes #1938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this isn't used very much at all, only for the Show typeclass, and
that's what was breaking here due to the introduction of
Cord. I thinkmy little hack is fine, it' just creates the cord out of the result of
the
showsmethod. However, I'm not 100% sure, so let's run the testsand see. I also removed scalaz concurrent because from what I can tell,
it wasn't being used and with the new version, it's not there anymore.
Supersedes #1938