Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): get rid of build warnings and unused things #1968

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 28, 2022

This pr is just some general cleanup.

  • Moves to slash syntax in sbt
  • Removes some unused sbt things
  • Moves some sbt setting inline if they are only used once

This pr is just some general cleanup.

- Moves to slash syntax in sbt
- Removes some unused sbt things
- Moves some sbt setting inline if they are only used once
@ckipp01 ckipp01 requested review from tgodzik and adpi2 December 28, 2022 10:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we could probably add the scalafix config and job now 🤔

@ckipp01 ckipp01 merged commit 6a447be into scalacenter:main Dec 28, 2022
@ckipp01
Copy link
Member Author

ckipp01 commented Dec 28, 2022

I think we could probably add the scalafix config and job now

Yea sure! Ha, there already is a .scalafix.conf, it's just not enforced.

@ckipp01 ckipp01 deleted the buildWarnings branch December 28, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants