improvement: Use diagnostic related information from the compiler #1986
+75
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like previously, this was totally ignored, so this should help, but not sure how to write tests until it's available in the compiler release. I also changed 2 deprecated usages of the zinc api.
tgodzik
force-pushed
the
use-diagns-related-info
branch
from
9222350 to
cbfd15f
Compare
ckipp01
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Yes, I was excited to see scala/scala3#16677 get merged! Agree, it's hard to test this without anything actually emitting this. I think when the compiler starts actually adding some of these we can add some tests.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like previously, this was totally ignored, so this should help, but not sure how to write tests until it's available in the compiler release.
I also changed 2 deprecated usages of the zinc api.