Fix timeout in DebugProtocolTests #2029
Merged
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been so long since I've seen a fully green CI, so if this truly fixes, I say let's go. |
tgodzik
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some mysterious reason, traversing the
src.zipof JDK Temurin 11.0.18 installed byactions/setup-javais very very slow. It takes up to 40 second, the first time, and then it takes about 500 ms. That's why theDebugProtocolSpectimes out.But if I install the exact same JDK with
coursier/setup-action, the issue disappears. Similarly, if I manually download and extract the JDK, it fixes the issue. So it seems there is something wrong withactions/setup-java, about how it installs this JDK, but I don't know exactly what.Switching to
coursier/setup-actionsolves the issue.