bugfix: Properly clean up orphan directories for internal classes #2032
Conversation
| @@ -177,7 +177,7 @@ object ResultsCache { | |||
| if (!cleanOrphanedInternalDirs) Task.unit | |||
| else { | |||
| val internalClassesDir = | |||
| CompileOutPaths.createInternalClassesRootDir(project.genericClassesDir) | |||
| CompileOutPaths.createInternalClassesRootDir(project.out) | |||
There was a problem hiding this comment.
Could you provide concrete values for project.out and project.genericClassesDir? Is one of them bloop-internal-classes?
There was a problem hiding this comment.
project.out is the currently used one for example /.bloop/input3/ while genericClassesDir is .bloop/input3/scala-3/classes, which is actually defined in the json file.
There was a problem hiding this comment.
I'm actually a bit surprised by this, I thought it would use the one specific to the scala version and therefore the nested on in .bloop/input3/scala-3/classes.
There was a problem hiding this comment.
That is kind of redundant since you can't have multiple Scala versions for one project, so I don't think it's really useful. Also, it's a smaller change to just ignore that directory :S
There was a problem hiding this comment.
also, it seems that we always use bloop-bsp-clients-classes always instead of classesDir, so this looks legit as if we had only a single output we could have issues with mutiple clients. (whether we could have mutiple BSP client for the same workspace is another thing altogether.)
There was a problem hiding this comment.
Can you add scaladoc which will explain what orphaned directories are? Giving some concrete examples you did int his thread will awesome
There was a problem hiding this comment.
Ok, more digging it seems the is an option for the tool to use managed classes directory, but there is even more logic on top of it to dermine it.
There was a problem hiding this comment.
That is kind of redundant since you can't have multiple Scala versions for one project, so I don't think it's really useful. Also, it's a smaller change to just ignore that directory :S
ah ok cool, thanks for the explanations 😄
There was a problem hiding this comment.
I added scaladoc to this method. I will probably dig in a bit more later on.
It seems that the genericClassesDir is not being used at all by the compiler, so cleaning orphan directories in it was not achieving anything. We might need to figure out how to use `genericClassesDir` and whether it needs to be used at all, but for now this fixes the issue of large .bloop directory.
It seems that the genericClassesDir is not being used at all by the compiler, so cleaning orphan directories in it was not achieving anything.
We might need to figure out how to use
genericClassesDirand whether it needs to be used at all, but for now this fixes the issue of large .bloop directory.