improvement: Don't fail on hashing, but use a random hash #2058
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when hashing would fail the whole compilation would also fail and while this seems incredibly rare let's try to guard ourselves here. Connected to scalacenter#2053
tgodzik
changed the title
adpi2
reviewed
May 25, 2023
No idea, I don't the filesystem is closed at any point, so my guess is that the jar is in an unexpected format. I hope we can shed some more light on this with the error message |
adpi2
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when hashing would fail the whole compilation would also fail and while this seems incredibly rare let's try to guard ourselves here.
Connected to #2053
It's the safest option, we could also try another stamp in this case, but I think there is something wrong with that jar