bugfix: Don't accept files other than .class or .jar as binary deps #2060
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok seems, this was not as easy :/ |
adpi2
approved these changes
May 31, 2023
|
Clicked the ✔️ button a bit fast: some tests are failing |
Should help with scalacenter#2053 The binary is described as: ``` A binary entry represents either the jar or the concrete class file from which the Scala compiler knows that <code>onBinaryClassName</code> comes from. ```
tgodzik
force-pushed
the
only-accept-class
branch
from
861762c to
77ca736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #2053
The binary is described as:
I am kind of lost here, since no idea how would this even pop up