-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Update zinc from 1.8.1 to 1.9.1 #2064
Conversation
Superseded by #2079. |
3712707
to
58fb709
Compare
I changed the tests since they were timing out on compilation (might be due to large bridges being compiled not sure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! One thing that was added to sbt 1.9.0 is the actions
inside of Problem
. In the Bloop Problem.scala
we aren't actually taking this into account yet. Are you able to add it and then also forward it on? If not after we merge this I can also add it in in another pr, but it should be pretty quick to add.
Hmm... do we put the bsp.ScalaAction into data field (from what I see in your metals PR)? Shouldn't that be a list? |
Correct, it will be a list of actions, but when it's coming from Problem it will be a list, and then we'll turn data into an object aka |
Also here is the PR for sbt if it helps to see how it was done there. sbt/sbt#7264 |
58fb709
to
987ab06
Compare
987ab06
to
291058a
Compare
Ok, I think it's done! Let me know if it makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Just one quick question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me! Thanks for taking care of this!
Updates org.scala-sbt:zinc from 1.8.1 to 1.9.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
Files still referring to the old version number
The following files still refer to the old version number (1.8.1).
You might want to review and update them manually.
Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1