bugfix: Include semanticdb plugin path in java options processorpath

[gersonsosa]

For projects that use javac "-processorpath" option append semanticdb plugin path to avoid compilation errors

Fixes:
#2059

[tgodzik]

Just got back to work this week, I am running the jobs and will take a look at the PR! Sorry for the delay.

[tgodzik]

Thanks for the great work! Added a couple of comments, but let's see if we can make the tests pass 🥇

[tgodzik]

I added you to triage role in the repo, so that I don't have to click approve every time. Let me know if you need help figuring out the tests!

[gersonsosa]

@tgodzik thank you, I think what's missing is adding bloop to the sample project 😅

[tgodzik]

I think we are almost there, but the windows tests are failing with:

--P:semanticdb:sourceroot:D:\a\bloop\bloop\frontend\src\test\resources\scala-java-processorpath
+-P:semanticdb:sourceroot:C:\Users\runneradmin\AppData\Local\Temp\bloop-test-workspace14905355409242014016

sourceroot is being set to the original resource directory and not the temporary workspace.

[tgodzik]

Weirdly enough it seems that on Windows we don't actually run within the created temporary workspace 🤔

I don't see any obvious reason for that, I can take a look on a windows machine tomorrow.

[gersonsosa]

@tgodzik I see, not running in a workspace is the reason for the difference in the test when asserting the workspace path.

I ran the tests on a windows machine, looks like the Compiler is unable to locate the semanticdb plugin on windows
I added some mode debugging and I get this from the compilation results

Compilation failed with results:
Failed(List(ProblemPerPhase(Problem(-1,Error,plug-in not found: semanticdb,,,Optional.empty),None)),None,10732,bloop.Compiler$$anon$3@776647f6)

After some trial and error the issue is that in windows you must use ; instead of : to separate classpath or processorpath entries for javac.
I'll try to make changes to fix it later today.

[gersonsosa]

@tgodzik I'm not sure if the last failure of the pipeline is related to the changes, I would appreciate you to take a look and let me know how to proceed 👍🏼

[tgodzik]

LGTM! The failing test was not related.