improvement: Try and find latest supported semanticdb version #2097
+88
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpodsiad
requested changes
Jun 30, 2023
Comment on lines
74
to
85
| def versionFuture = | ||
| Task { | ||
| coursierapi.Complete | ||
| .create() | ||
| .withScalaVersion(scalaVersion) | ||
| .withScalaBinaryVersion(scalaVersion.split('.').take(2).mkString(".")) | ||
| .withInput(s"org.scalameta:semanticdb-scalac_$scalaVersion:") | ||
| .complete() | ||
| .getCompletions() | ||
| .asScala | ||
| .lastOption | ||
| } |
There was a problem hiding this comment.
nitpick - versionFuture returns Task despite its name. Moreover, you're instantly converting it to future via versionFuture.runAsync(ExecutionContext.ioScheduler), maybe you could go to the Future directly on ExecutionContext.ioSchedulerz? There is no point in using Task in this case.
There was a problem hiding this comment.
Sure, I just wanted to be consistent, but maybe it doesn't really make sense. Changed!
Previously, we wouldn't produce semanticdb files for older version of Scala since we wouldn't find the correct artifact if we stopped publishing for a particular version. Now, we try and find the latest version that still supported that Scala version. This is similar to the change we did in Metals in regards to the presentation compiler interface, where we would fetch old mtags for unsupported scala version and this way always support a particular version.
tgodzik
force-pushed
the
fallback-semanticdb
branch
from
062edc0 to
c8d68ab
Compare
kpodsiad
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we wouldn't produce semanticdb files for older version of Scala since we wouldn't find the correct artifact if we stopped publishing for a particular version.
Now, we try and find the latest version that still supported that Scala version.
This is similar to the change we did in Metals in regards to the presentation compiler interface, where we would fetch old mtags for unsupported scala version and this way always support a particular version.
Will do a similar thing for our Metals sbt plugin if it makes sense.