chore: Revert JGit to a version compatible with JDK 8 #2101
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
requested changes
Jul 5, 2023
| "org.eclipse.jgit" % "org.eclipse.jgit" % "6.6.0.202305301015-r", | ||
| "org.eclipse.jgit" % "org.eclipse.jgit.ssh.jsch" % "6.6.0.202305301015-r", | ||
| "org.eclipse.jgit" % "org.eclipse.jgit" % "5.13.2.202306221912-r", | ||
| "org.eclipse.jgit" % "org.eclipse.jgit.ssh.jsch" % "5.13.2.202306221912-r", |
There was a problem hiding this comment.
Can we add a comment here as to why we are leaving at this version? I know we'll try to fix all this later, but just in case it might be good to make sure we have this noted so we don't accidentally let steward update it again.
There was a problem hiding this comment.
The good thing here is that they currently have concurrent 5 and 6 versions, so this is not too old. I will add that!
Alternative would be adding everywhere the -release option, but since we plan to drop the support later on, I think it's easier to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative would be adding everywhere the -release option, but since we plan to drop the support later on, I think it's easier to do this.
The release job failed because of it, I will be updating the integrations or Bloop itself later on.