Merge pull request #408 from xuwei-k/patch-1

fix JGitCompletions memory leak

src/main/scala/scalafix/internal/sbt/JGitCompletions.scala

@@ -18,32 +18,41 @@ class JGitCompletion(cwd: Path) {
     RepositoryCache.FileKey
       .isGitRepository(cwd.resolve(DOT_GIT).toFile, FS.DETECTED)
 
-  private val (refList, refs) =
+  val branchesAndTags: List[String] = {
     if (isGitRepository) {
       val builder = new FileRepositoryBuilder()
       val repo = builder.readEnvironment().setWorkTree(cwd.toFile).build()
-      val refList0 =
+      val refList =
         repo.getRefDatabase().getRefsByPrefix(RefDatabase.ALL).asScala
-      val git = new Git(repo)
-      val refs0 =
-        Try(git.log().setMaxCount(20).call().asScala.toList).getOrElse(Nil)
-      (refList0, refs0)
+      refList.map { ref => Repository.shortenRefName(ref.getName) }.toList
     } else {
-      (Nil, Nil)
+      Nil
     }
-
-  val branchesAndTags: List[String] =
-    refList.map { ref => Repository.shortenRefName(ref.getName) }.toList
+  }
 
   private val dateFormatter = new GitDateFormatter(
     GitDateFormatter.Format.RELATIVE
   )
-  val last20Commits: List[(String, String)] =
+  val last20Commits: List[(String, String)] = {
+    val refs = {
+      if (isGitRepository) {
+        val builder = new FileRepositoryBuilder()
+        val repo = builder.readEnvironment().setWorkTree(cwd.toFile).build()
+        val git = new Git(repo)
+        val refs0 =
+          Try(git.log().setMaxCount(20).call().asScala.toList).getOrElse(Nil)
+        refs0
+      } else {
+        Nil
+      }
+    }
+
     refs.map { ref =>
       val relativeCommitTime =
         dateFormatter.formatDate(refs.head.getCommitterIdent)
       val abrev = ref.abbreviate(8).name
       val short = ref.getShortMessage
       (s"$abrev -- $short ($relativeCommitTime)", abrev)
     }
+  }
 }