Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scalafixJGitCompletion key. reduce memory usage #405

Merged
merged 2 commits into from Mar 23, 2024

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Mar 23, 2024

Maybe partially(?) fix scalacenter/scalafix#1965 if there are many sub projects

if there is example sbt project as follow

lazy val p1 = project
lazy val p2 = project
lazy val p3 = project
lazy val p4 = project.disablePlugins(ScalafixPlugin)

before

(p1 + p2 + p3 + implicit root project) * ( Compile/scalafix + Test/scalafix + scalafixAll )
= 4 * 3
= 12JGitCompletion instances

after

only one JGitCompletion instance

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into that @xuwei-k !

src/main/scala/scalafix/sbt/ScalafixPlugin.scala Outdated Show resolved Hide resolved
src/main/scala/scalafix/sbt/ScalafixPlugin.scala Outdated Show resolved Hide resolved
src/main/scala/scalafix/sbt/ScalafixPlugin.scala Outdated Show resolved Hide resolved
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
@bjaglin bjaglin merged commit aba1063 into scalacenter:main Mar 23, 2024
6 checks passed
@xuwei-k xuwei-k deleted the reduce-memory branch March 23, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants