Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-java8-compat to 1.0.2 #1719

Merged
merged 1 commit into from Apr 15, 2023
Merged

Conversation

scala-center-steward[bot]
Copy link
Contributor

Updates org.scala-lang.modules:scala-java8-compat from 0.9.1 to 1.0.2.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.9.1).
You might want to review and update them manually.

CONTRIBUTING.md
project/Dependencies.scala
scalafix-tests/unit/src/test/scala/scalafix/tests/cli/CompatibilitySuite.scala
scalafix-tests/unit/src/test/scala/scalafix/tests/interfaces/ScalafixSuite.scala
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-java8-compat" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang.modules", artifactId = "scala-java8-compat" }
}]

labels: library-update, early-semver-major, semver-spec-major, old-version-remains, commit-count:1

@bjaglin
Copy link
Collaborator

bjaglin commented Jan 2, 2023

[error] org.scala-lang.modules:scala-java8-compat_2.11: incompatible version change from 0.9.0 to 1.0.2 (compatibility: early semantic versioning)

it does look like we should be fine with 1.0.2 though, to confirm

@SethTisue
Copy link
Contributor

Yes, I would recommend taking this upgrade.

@bjaglin bjaglin force-pushed the update/scala-java8-compat-1.0.2 branch 3 times, most recently from b8f7560 to 00ba74d Compare April 15, 2023 16:19
@bjaglin bjaglin force-pushed the update/scala-java8-compat-1.0.2 branch from 00ba74d to 123f2cc Compare April 15, 2023 16:28
@bjaglin bjaglin merged commit 87fb44f into main Apr 15, 2023
9 checks passed
@bjaglin bjaglin deleted the update/scala-java8-compat-1.0.2 branch May 1, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants