Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: adjust java version/java home descriptions/scopes #1471

Merged
merged 1 commit into from Mar 14, 2024
Merged

improvement: adjust java version/java home descriptions/scopes #1471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/metals-vscode/package.json
View file
Open in desktop
Expand Up @@ -270,7 +270,7 @@
"metals.javaHome": {
"type": "string",
"scope": "machine-overridable",
"markdownDescription": "Optional path to the Java home directory. Requires reloading the window.\n\nDefaults to Java 17 (or another version specified in javaVersion) downloaded by coursier."
"markdownDescription": "Optional path to the Java home directory that will be used for compiling the project.\n\nDefaults to JDK used by Metals's server (look: Java Version).\n\nThis Java version should be lower or equal to JDK version used by the Metals's server."
},
"metals.javaVersion": {
"type": "string",
Expand All @@ -280,8 +280,8 @@
"17",
"21"
],
"scope": "machine-overridable",
"markdownDescription": "Optional Java version to start metals with."
"scope": "machine",
"markdownDescription": "JDK version used for running the Metals's server.\n\nShould be greater or equal to the JDK version used for the project (look: Java Home)."
},
"metals.sbtScript": {
"type": "string",
Expand Down