improvement: Search PATH for Java to use #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would rely on the separate library for detecting java, but we had no control on whether it worked and it doesn't seem actively used by a lot of people. Now, we first check JAVA_HOME and then search PATH for the actual Java to use. If we can't find any of that we download ourselves. This seems simple enought logic.
tgodzik
force-pushed
the
add-path-back
branch
3 times, most recently
from
5f8ce82
to
2ac85f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would rely on the separate library for detecting java, but we had no control on whether it worked and it doesn't seem actively used by a lot of people.
Now, we first check JAVA_HOME and then search PATH for the actual Java to use. If we can't find any of that we download ourselves. This seems simple enought logic.