Skip to content

Commit

Permalink
chore: Adjust to changes in Scalafix
Browse files Browse the repository at this point in the history
  • Loading branch information
tgodzik committed Mar 10, 2024
1 parent efead65 commit f5e8afe
Show file tree
Hide file tree
Showing 9 changed files with 34 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .jvmopts
@@ -1,6 +1,6 @@
-Xss4m
-Xms1G
-Xmx2G
-Xmx3G
-XX:ReservedCodeCacheSize=1024m
-XX:+TieredCompilation
-Dfile.encoding=UTF-8
1 change: 1 addition & 0 deletions .scalafix3.conf
Expand Up @@ -11,3 +11,4 @@ OrganizeImports.groups = [
"scala.meta."
"*"
]
OrganizeImports.targetDialect = StandardLayout
2 changes: 2 additions & 0 deletions .scalafmt.conf
Expand Up @@ -21,6 +21,8 @@ project.excludeFilters = [
"tests/unit/src/test/resources"
"tests/input/src/main/scala"
"mtags/src/main/scala-2.11/scala/tools/nsc/symtab/classfile/ClassfileParser.scala"
"mtags/src/main/scala-3-wrapper"
"mtags/src/main/scala-3."
]

fileOverride {
Expand Down
Expand Up @@ -271,6 +271,7 @@ case class ScalafixProvider(
| OrganizeImports
|]
|OrganizeImports.removeUnused = false
|OrganizeImports.targetDialect = Scala3
|
|""".stripMargin
)
Expand Down Expand Up @@ -376,6 +377,7 @@ case class ScalafixProvider(
val classpath =
(targetRoot.toList ++ scalaTarget.fullClasspath).asJava

val isSource3 = scalaTarget.scalac.getOptions().contains("-Xsource:3")
for {
api <- getScalafix(scalaBinaryVersion)
urlClassLoaderWithExternalRule <- getRuleClassLoader(
Expand All @@ -389,7 +391,7 @@ case class ScalafixProvider(
if (scalaBinaryVersion == "2.13") list.add("-Wunused:imports")
else list.add("-Ywarn-unused-import")

if (!isScala3 && scalaTarget.scalac.getOptions().contains("-Xsource:3"))
if (!isScala3 && isSource3)
list.add("-Xsource:3")

// We always compile with synthetics:on but scalafix will fail if we don't set it here
Expand All @@ -402,7 +404,7 @@ case class ScalafixProvider(
.withScalaVersion(scalaVersion)
.withClasspath(classpath)
.withToolClasspath(urlClassLoaderWithExternalRule)
.withConfig(scalafixConf(isScala3).asJava)
.withConfig(scalafixConf(isScala3 || isSource3).asJava)
.withRules(rules.asJava)
.withPaths(List(diskFilePath.toNIO).asJava)
.withSourceroot(sourceroot.toNIO)
Expand Down
Expand Up @@ -5,11 +5,11 @@ import java.nio.file.Path
import java.util.concurrent.CompletableFuture
import java.util.concurrent.ExecutorService
import java.util.concurrent.ScheduledExecutorService
import java.{util as ju}
import java.{util => ju}

import scala.concurrent.ExecutionContext
import scala.concurrent.ExecutionContextExecutor
import scala.jdk.CollectionConverters.*
import scala.jdk.CollectionConverters._

import scala.meta.internal.metals.ReportLevel
import scala.meta.pc.AutoImportsResult
Expand All @@ -24,7 +24,7 @@ import scala.meta.pc.RangeParams
import scala.meta.pc.SymbolSearch
import scala.meta.pc.VirtualFileParams

import dotty.tools.pc.{ScalaPresentationCompiler as DottyPresentationCompiler}
import dotty.tools.pc.{ScalaPresentationCompiler => DottyPresentationCompiler}
import org.eclipse.lsp4j.CompletionItem
import org.eclipse.lsp4j.CompletionList
import org.eclipse.lsp4j.Diagnostic
Expand Down
@@ -1,9 +1,9 @@
package scala.meta.internal.pc.printer

import dotty.tools.dotc.core.Contexts.Context
import dotty.tools.dotc.core.Flags.*
import dotty.tools.dotc.core.StdNames.*
import dotty.tools.dotc.core.Types.*
import dotty.tools.dotc.core.Flags._
import dotty.tools.dotc.core.StdNames._
import dotty.tools.dotc.core.Types._
import dotty.tools.dotc.printing.RefinedPrinter
import dotty.tools.dotc.printing.Texts.Text

Expand Down
@@ -1,8 +1,8 @@
package scala.meta.internal.pc

import dotty.tools.dotc.core.Contexts.Context
import dotty.tools.dotc.core.Flags.*
import dotty.tools.dotc.core.StdNames.*
import dotty.tools.dotc.core.Flags._
import dotty.tools.dotc.core.StdNames._
import dotty.tools.dotc.core.Symbols.Symbol

object MetalsSealedDesc:
Expand Down
@@ -1,8 +1,8 @@
package scala.meta.internal.pc

import dotty.tools.dotc.ast.tpd
import dotty.tools.dotc.core.Contexts.*
import dotty.tools.dotc.core.Denotations.*
import dotty.tools.dotc.core.Contexts._
import dotty.tools.dotc.core.Denotations._
import dotty.tools.dotc.util.Signatures
import dotty.tools.dotc.util.Signatures.Signature
import dotty.tools.dotc.util.SourcePosition
Expand Down
Expand Up @@ -212,23 +212,29 @@ class OrganizeImportsLspSuite
|import scala.concurrent.duration.*
|import scala.concurrent.{Future<<>> as ScalaFuture}
|import scala.concurrent.ExecutionContext.global
|import scala.concurrent.ExecutionContext
|
|object A {
| implicit val ec: ExecutionContext = global
| val d = Duration(10, MICROSECONDS)
| val k = ScalaFuture.successful(1)
| ScalaFuture{ println("Hello!") }
|}
|""".stripMargin,
s"${SourceOrganizeImports.title}",
"""
|package a
|import scala.concurrent.duration.*
|import scala.concurrent.{Future as ScalaFuture}
|
|object A {
| val d = Duration(10, MICROSECONDS)
| val k = ScalaFuture.successful(1)
|}
|""".stripMargin,
"""|package a
|import scala.concurrent.ExecutionContext
|import scala.concurrent.ExecutionContext.global
|import scala.concurrent.Future as ScalaFuture
|import scala.concurrent.duration.*
|
|object A {
| implicit val ec: ExecutionContext = global
| val d = Duration(10, MICROSECONDS)
| val k = ScalaFuture.successful(1)
| ScalaFuture{ println("Hello!") }
|}
|""".stripMargin,
kind = List(sourceKind),
scalacOptions = scalacOption ++ List("-Xsource:3"),
)
Expand Down

0 comments on commit f5e8afe

Please sign in to comment.