Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Remove bazel specific directories when running full clean #6205

Merged
merged 1 commit into from Mar 12, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 7, 2024

I also added a small refactor to not use plain strings for the two directories being removed.

@tgodzik tgodzik requested a review from jkciesluk March 7, 2024 19:04
@tgodzik tgodzik force-pushed the remove-bazel-bsp branch 2 times, most recently from e4d76b2 to 43d2f5e Compare March 8, 2024 17:54
@tgodzik tgodzik requested a review from jkciesluk March 8, 2024 17:55
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just adjust the test, looks like it fails after merging #6164

I also added a small refactor to not use plain strings for the two directories being removed.
@tgodzik tgodzik merged commit 7a4dfb7 into scalameta:main Mar 12, 2024
25 of 26 checks passed
@tgodzik tgodzik deleted the remove-bazel-bsp branch March 12, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants