Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: go to implementations for multi-module projects #6211

Merged
merged 2 commits into from Mar 14, 2024

Conversation

kasiaMarek
Copy link
Contributor

resolves: #6206

@filipwiech
Copy link
Contributor

Thank you for a quick fix! 👍

@@ -659,6 +663,57 @@ class ImplementationLspSuite extends BaseImplementationSuite("implementation") {
|""".stripMargin,
)

test("multi-module") {
val fileName = "a/src/main/scala/com/example/foo/Foo.scala"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we instead add a parameter to check method to have a custom metals.json?

@kasiaMarek kasiaMarek requested a review from tgodzik March 14, 2024 15:13
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasiaMarek kasiaMarek merged commit fe430b2 into scalameta:main Mar 14, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metals cannot find cross-module implementations within the project
3 participants