improvement: Use dependencyModule for resolving sources #6213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
dependency-modules
branch
2 times, most recently
from
a77686b
to
de78cd7
Compare
tgodzik
force-pushed
the
dependency-modules
branch
10 times, most recently
from
548ffd7
to
6ff2a72
Compare
|
Looks to be working, I had an issue with letter cases for windows jar paths. |
kasiaMarek
reviewed
Mar 15, 2024
metals/src/main/scala/scala/meta/internal/metals/BuildTargets.scala
Outdated
Show resolved
Hide resolved
Previously, we would assume that the source jar is in the same directory as the normal jar. Now we use dependencyModules for that and only fallback to the previous logic if we can't find the jar in dependency modules. This extracts part of the lazy classpath PR Fixes scalameta#6182
tgodzik
force-pushed
the
dependency-modules
branch
from
6ff2a72
to
d578eba
Compare
kasiaMarek
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would assume that the source jar is in the same directory as the normal jar. Now we use dependencyModules for that and only fallback to the previous logic if we can't find the jar in dependency modules.
This extracts part of the lazy classpath PR
Fixes #6182