Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Check if compiled unit is available before using #6216

Merged
merged 1 commit into from Mar 12, 2024
Merged

improvement: Check if compiled unit is available before using #6216

merged 1 commit into from Mar 12, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 10, 2024

@tgodzik tgodzik requested a review from jkciesluk March 10, 2024 12:49
jkciesluk
jkciesluk reviewed Mar 10, 2024
View reviewed changes
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
We should probably also change it in PcCollector

@tgodzik
Copy link
Contributor Author

tgodzik commented Mar 11, 2024

Good idea. We should probably also change it in PcCollector

Somehow I missed that despite it was what I started with 😓

@tgodzik tgodzik requested a review from jkciesluk March 11, 2024 13:02
@tgodzik tgodzik merged commit 9590166 into scalameta:main Mar 12, 2024
26 checks passed
@tgodzik tgodzik deleted the fix-head branch March 12, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkciesluk jkciesluk jkciesluk approved these changes

Assignees

@kasiaMarek kasiaMarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @jkciesluk @kasiaMarek