improvement: Request jvmRunEnvironment lazily #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
reviewed
Mar 13, 2024
| buildTargetClasses.jvmRunEnvironment | ||
| .get(target) | ||
| buildTargetClasses | ||
| .jvmRunEnvironmentSync(target) |
There was a problem hiding this comment.
Just a question, can we ask for jvmRunEnvironment here instead? This would remove the need for jvmRunEnvironmentSync, since jvmRunEnvironment can return cached results.
Or maybe waiting for the response here would be too long?
There was a problem hiding this comment.
I would rather avoid using Await here and using Future propagates it all the way and it becomes quite complex. There are multiple sequences of futures etc.
kasiaMarek
reviewed
Mar 14, 2024
Goo catch, I added it to |
Previously, we would eagerly request jvmEnvironment for all known main classes, which in case of Bazel might cause a lot of queries. This might also not be efficient in some other cases. Now, we only request and cache jvmRunEnvironment when needed.
kasiaMarek
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would eagerly request jvmEnvironment for all known main classes, which in case of Bazel might cause a lot of queries. This might also not be efficient in some other cases. Now, we only request and cache jvmRunEnvironment when needed.