Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take last change in didChange #6237

Merged
merged 1 commit into from Mar 26, 2024
Merged

fix: take last change in didChange #6237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala
View file
Open in desktop
Expand Up @@ -1137,8 +1137,15 @@ class MetalsLspService(

override def didChange(
params: DidChangeTextDocumentParams
): CompletableFuture[Unit] =
params.getContentChanges.asScala.headOption match {
): CompletableFuture[Unit] = {
val changesSize = params.getContentChanges.size()
if (changesSize != 1) {
scribe.debug(
s"did change notification contained $changesSize content changes, expected 1"
)
}

params.getContentChanges.asScala.lastOption match {
case None => CompletableFuture.completedFuture(())
case Some(change) =>
val path = params.getTextDocument.getUri.toAbsolutePath
Expand All @@ -1152,6 +1159,7 @@ class MetalsLspService(
.ignoreValue
.asJava
}
}

override def didClose(params: DidCloseTextDocumentParams): Unit = {
val path = params.getTextDocument.getUri.toAbsolutePath
Expand Down