Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LegacyTokenData: relax float check, round up max #3655

Merged
merged 3 commits into from Mar 17, 2024
Merged

LegacyTokenData: relax float check, round up max #3655

merged 3 commits into from Mar 17, 2024

Conversation

kitbellew
Copy link
Contributor

Fixes #3654.

@kitbellew kitbellew changed the title LegacyTokenData: relax float check, max as decimal LegacyTokenData: relax float check, round up max Mar 16, 2024
@kitbellew kitbellew requested a review from tgodzik March 16, 2024 19:22
tgodzik
tgodzik approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitbellew kitbellew merged commit ceb3bad into scalameta:main Mar 17, 2024
24 checks passed
@kitbellew kitbellew deleted the 3654 branch March 17, 2024 11:38
kitbellew added a commit to kitbellew/scalameta that referenced this pull request Mar 17, 2024
@kitbellew
Tests: fix scalameta#3655 after change in scalameta#3660
5f1f330
kitbellew added a commit that referenced this pull request Mar 17, 2024
@kitbellew
Tests: fix #3655 after change in #3660 (#3662)
1381dfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When I define a Float with value 3.4028235e38f and run scalafmt, an error occurs.
2 participants
@kitbellew @tgodzik