Simplify macro compat #533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult in methodNotAllowed.
| routes.appendBeforeFilter(Route(transformers, () => fun)) | ||
| } | ||
|
|
||
| private[scalatra] def after0(transformers: RouteTransformer*)(fun: => Any): Unit = { | ||
| protected def appendAfterFilter(transformers: RouteTransformer*)(fun: => Any): Unit = { |
There was a problem hiding this comment.
Why do you want to change this access modifier? #511 (comment)
There was a problem hiding this comment.
It enables a library user to use this method, in the case he does not want or can not use the macro.
|
This looks good to me. I share @seratch's question about the visibility change. I am not a macro expert, so I'm relying heavily on the tests still passing with my 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-structures code and fixes some warnings:
macroutilspackage