Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Some instead Option for unapply #1535

Merged
merged 1 commit into from Mar 15, 2022
Merged

use Some instead Option for unapply #1535

merged 1 commit into from Mar 15, 2022

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Mar 14, 2022

@xuwei-k xuwei-k requested a review from seratch as a code owner March 14, 2022 23:12
seratch
seratch approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This change looks good to me

@seratch seratch added the core label Mar 14, 2022
@seratch seratch added this to the version 4.1.x milestone Mar 14, 2022
@xuwei-k xuwei-k merged commit bbc604d into scalikejdbc:master Mar 15, 2022
@xuwei-k xuwei-k deleted the unapply-return-Some branch March 15, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seratch seratch seratch approved these changes

Assignees
No one assigned
Labels
core
Milestone
version 4.1.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuwei-k @seratch