Skip to content
This repository has been archived by the owner on Nov 24, 2018. It is now read-only.

fix(package): pins serverless-plugin-chrome to 1.0.0-38 (fix #387) #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nsfmc
Copy link

@nsfmc nsfmc commented Mar 13, 2018

This fixes the vague Error: Unknown command: protocol error (#387).

pinned version found via a similar issue report:
adieuadieu/serverless-chrome#120

  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

This fixes the vague `Error: Unknown command: protocol` error (schickling#387).

pinned version found via a similar issue report:
adieuadieu/serverless-chrome#120
@nsfmc nsfmc changed the title fix(package): pins serverless-plugin-chrome to 1.0.0-38 fix(package): pins serverless-plugin-chrome to 1.0.0-38 (fix #387) Mar 13, 2018
@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #415 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #415   +/-   ##
=======================================
  Coverage   38.03%   38.03%           
=======================================
  Files           7        7           
  Lines         844      844           
  Branches      116      116           
=======================================
  Hits          321      321           
  Misses        523      523

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f172e64...6f0e5b4. Read the comment docs.

@adieuadieu
Copy link
Collaborator

Do we still need to pin to serverless-plugin-chrome@1.0.0-38 or does the latest version of serverless-plugin-chrome resolve the Error: Unknown command: protocol issue?

@ivnaru
Copy link

ivnaru commented Jul 12, 2018

I just fixed this issue pinning to 1.0.0-38, before I was using the last version of the plugin

@nsfmc
Copy link
Author

nsfmc commented Jul 12, 2018

@arielmcm were you having the same Error: unknown command: protocol issue until pinning back to 1.0.0-38? if so, this commit should probably be looked at again.

if there's a separate solution (or upstream serverless-plugin-chrome is fixed) i'm happy to close it.

@ivnaru
Copy link

ivnaru commented Jul 12, 2018

@nsfmc yes, same exact Error: unknown command: protocol error before pining to 1.0.0-38

@nsfmc
Copy link
Author

nsfmc commented Jul 12, 2018

@adieuadieu would you mind taking another look at this or let me know if you think i should close this pr?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants