-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add audio_webfile_start/audio_webfile_data_received/audio_stopped callbacks #667
base: master
Are you sure you want to change the base?
Conversation
What can you use it for? |
I'm using it to stream webfiles and save them to SD while playing. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
b8e4171
to
a204cf1
Compare
I've rebased the PR. Do you have any alternative suggestion for the use case? |
Might be useful to cache TTS. For example I use TTS to get notified about Home Assistant TTS events. Imagine you have TTS notifications like "Hey, a movement has been detected in basement". Instead of asking for TTS sentence, it can be cached using md5 of the sentence adding the language as salt. Seems like a good feature candidate anyway. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@schreibfaul1 any comment on this? If you plan to merge it, I'll rebase it on master again. |
you can query |
That doesn't give me access to the input buffer and we would have to use busy waiting (inefficient) to get something similar to the webfile_start/stopped callback. Are your concerns only with the webfile_start and stopped callback? |
Adds the following callbacks:
And adds the existing
audio_eof_stream
callback to the readme