Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support artifact v4 #438

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Dec 15, 2023

Hopefully supporting actions/artifact@v2. See pypa/cibuildwheel#1699, using fix there and in scientific-python/cookie#335. There's an issue asking for guidance here: actions/upload-artifact#472.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@jcfr
Copy link
Contributor

jcfr commented Dec 15, 2023

Thanks for the fix 🙏

.github/workflows/build.yml Outdated Show resolved Hide resolved
@henryiii henryiii merged commit 83a0f29 into scikit-build:master Dec 15, 2023
24 checks passed
@henryiii henryiii deleted the henryiii/fix/updown branch December 15, 2023 15:35
jcfr added a commit to mayeut/cmake-python-distributions that referenced this pull request Feb 15, 2024
* master: (112 commits)
  docs: fix up docs (scikit-build#454)
  chore(deps): update pre-commit hooks (scikit-build#443)
  chore(deps): bump cmake from 3.28.1 to 3.28.3 (scikit-build#452)
  chore(deps): bump the actions group with 1 update (scikit-build#453)
  Update to CMake 3.28.3 (scikit-build#450)
  chore(ci): use 4 threads to compile on GHA (scikit-build#449)
  Update to OpenSSL 3.0.13 (scikit-build#448)
  chore(deps): bump the actions group with 1 update (scikit-build#447)
  chore(deps): update pre-commit hooks (scikit-build#441)
  ci: group dependabot updates (scikit-build#442)
  chore(deps): bump cmake from 3.27.9 to 3.28.1 (scikit-build#440)
  Update to CMake 3.28.1 (scikit-build#439)
  ci: support artifact v4 (scikit-build#438)
  chore(deps): bump actions/upload-artifact from 3 to 4
  chore(deps): bump actions/download-artifact from 3 to 4
  Update to CMake 3.28.0
  chore(deps): update pre-commit hooks
  chore(deps): bump actions/setup-python from 4 to 5 (scikit-build#431)
  chore(deps): bump cmake from 3.27.7 to 3.27.9 (scikit-build#430)
  Update to CMake 3.27.9 (scikit-build#429)
  ...
jcfr added a commit to mayeut/cmake-python-distributions that referenced this pull request Feb 15, 2024
* master: (112 commits)
  docs: fix up docs (scikit-build#454)
  chore(deps): update pre-commit hooks (scikit-build#443)
  chore(deps): bump cmake from 3.28.1 to 3.28.3 (scikit-build#452)
  chore(deps): bump the actions group with 1 update (scikit-build#453)
  Update to CMake 3.28.3 (scikit-build#450)
  chore(ci): use 4 threads to compile on GHA (scikit-build#449)
  Update to OpenSSL 3.0.13 (scikit-build#448)
  chore(deps): bump the actions group with 1 update (scikit-build#447)
  chore(deps): update pre-commit hooks (scikit-build#441)
  ci: group dependabot updates (scikit-build#442)
  chore(deps): bump cmake from 3.27.9 to 3.28.1 (scikit-build#440)
  Update to CMake 3.28.1 (scikit-build#439)
  ci: support artifact v4 (scikit-build#438)
  chore(deps): bump actions/upload-artifact from 3 to 4
  chore(deps): bump actions/download-artifact from 3 to 4
  Update to CMake 3.28.0
  chore(deps): update pre-commit hooks
  chore(deps): bump actions/setup-python from 4 to 5 (scikit-build#431)
  chore(deps): bump cmake from 3.27.7 to 3.27.9 (scikit-build#430)
  Update to CMake 3.27.9 (scikit-build#429)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants