Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CMake 3.29.0 #467

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Mar 21, 2024

Created by running nox -s bump -- --commit

I've also pushed a final py2 release with scikit-build classic of 3.28.4 with Python 2 support fixed (it's been broken for quite a while, at least accessing it from Python has).

@henryiii
Copy link
Contributor Author

This is failing on MUSL with the following error:

 CMake Error at /project/CMake-src/Tests/RunCMake/RunCMake.cmake:280 (message):
      Stub-fail - FAILED:
  
      stderr does not match that expected.
  
      Command was:
  
       command> "/project/build/py3-none-musllinux_1_1_x86_64/CMakeProject-build/bin/cmake" "-E" "env" "LANG=C" "/project/build/py3-none-musllinux_1_1_x86_64/CMakeProject-build/Tests/RunCMake/RuntimePath/Stub-build/StubExe"
  
      Actual stdout:
  
       actual-stdout>
  
      Expected stderr to match:
  
       expect-stderr> (error while loading shared libraries: libStub\.so\.1|Library not loaded: '?@rpath/libStub\.1\.dylib'?|(Cannot|Could not) load module libStub\.so|fatal: libStub\.so\.1: open failed|Shared object "libStub\.so\.1" not found)
  
      Actual stderr:
  
       actual-stderr> Error loading shared library libStub.so.1: No such file or directory (needed by /project/build/py3-none-musllinux_1_1_x86_64/CMakeProject-build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so)
       actual-stderr> Error relocating /project/build/py3-none-musllinux_1_1_x86_64/CMakeProject-build/Tests/RunCMake/RuntimePath/Stub-build/libStubUse.so: Stub: symbol not found
  
    Call Stack (most recent call first):
      /project/CMake-src/Tests/RunCMake/RunCMake.cmake:288 (run_cmake)
      /project/CMake-src/Tests/RunCMake/RuntimePath/RunCMakeTest.cmake:56 (run_cmake_command)

henryiii and others added 2 commits March 25, 2024 15:44
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii merged commit 091357e into scikit-build:main Mar 25, 2024
23 checks passed
@henryiii henryiii deleted the update-to-cmake-3.29.0 branch March 25, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants