-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Header-only fix is_valid for empty Indexed or IndexedOption #3120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good fix—thanks for catching it!
I'll merge this PR as soon as we get the MacOS bug fixed. I think we'll get that done tomorrow, even if we have to put an upper limit on the pyarrow version we accept.
@jpivarski Since the MacOS bug is fixed, this can be merged, right? |
Yes, the MacOS bug was the only thing holding it back. I'll merge it now. |
Noticed that the implementation of
is_valid
in #3901did not handle correctly empty objects.
In that case
max_index_
has the initial value of 0the length of content is also 0.
Therefore
is_valid
fails because they are equal.Added 2 test cases for this to the same file given they are related.