feat : add ratioplot #416
Open
feat : add ratioplot #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ming-Yan
commented
Apr 3, 2023
•
Ming-Yan
commented
- add ratioplot function originate from coffea.hist.plotratio
- add test function
|
hi @Ming-Yan what's the status of this? Can you maybe rebase the PR? |
|
Hi @jonas-eschle sorry for the long delayed, indeed I only made the ratio plot available for the boost hist object only but did not have time to investigate further. I can do rebase for the changes. |
|
The ci currently fails, there seems to be still issues, can you have a look at it? Also, is there a discussion/issue somewhere where the rationals of the functions are discussed? I.e. interface, defaults? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.