Simplify warning filters in test suite #7349
Merged
+21
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to make our test suite configuration less complex and opaque. Having a hidden `setup_test` with warning filters is less obvious than using pytests official support for it. Also remove filters that are not longer needed.
Neither NumPy's linspace nor called functions in our color module can really deal with the max and min value supported by float64. As we might deprecate this plugin system soon, just ignore it.
According to the CI apparently none of these are needed anymore...
jarrodmillman
approved these changes
Apr 3, 2024
Closed
jarrodmillman
added a commit
to jarrodmillman/scikit-image
that referenced
this pull request
Feb 27, 2025
Merged
stefanv
pushed a commit
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is to remove technical debt, simplify our test suite and rely on pytest as much as possible instead of cooking our own custom solutions. This way we have less to maintain and contributors (and maintainers) can use standard tooling which should be a much smaller barrier.
This PR mainly removes / replaces the whole machinery around
SKIMAGE_TEST_STRICT_WARNINGS_GLOBALand also outdated warning filters.Checklist
./doc/examplesfor new featuresRelease note
We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.