FIX Ignore distutils warning in scipy-dev [scipy-dev] #21517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cab39ec.
thomasjpfan
commented
Nov 1, 2021
There was a problem hiding this comment.
The last test failure is a warning in test_dbscan_metric_params is related to numpy/numpy#17582 where there is a RuntimeWarning:
RuntimeWarning('Trying to dealloc data, but a memory policy is not set. If you take ownership of the data, you must set a base owning the data (e.g. a PyCapsule).'
| @@ -544,7 +544,7 @@ def transform(self, X): | |||
|
|
|||
| indptr = np.empty(n_samples + 1, dtype=int) | |||
| indptr[0] = 0 | |||
| np.sum(X_mask, axis=1, out=indptr[1:]) | |||
| np.sum(X_mask, axis=1, out=indptr[1:], dtype=indptr.dtype) | |||
There was a problem hiding this comment.
This is a major fix for numpy 1.22 otherwise the encoder does not work at all. I think this should be backported to 1.0.2.
thomasjpfan
changed the title
ogrisel
added
the
To backport
ogrisel
changed the title
ogrisel
approved these changes
Nov 4, 2021
|
Yeah! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Nov 29, 2021
…in OneHotEncoder (scikit-learn#21517) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…in OneHotEncoder (scikit-learn#21517) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
…in OneHotEncoder (scikit-learn#21517) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
…in OneHotEncoder (#21517) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
mathijs02
pushed a commit
to mathijs02/scikit-learn
that referenced
this pull request
Dec 27, 2022
…in OneHotEncoder (scikit-learn#21517) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses some of #21524
Related to #21499
What does this implement/fix? Explain your changes.
The scipy-dev main build is failing because numpy imports distuils.sysconfig` during test collection time.