Router: remove most uses of net.UDPAddr in favor of netip.AddrPort #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
(Well... that's the intent anyway).
A pointer being a bit smaller than a net.UDPAddr, there's some gains in only copying the reference. However, we allocate it only once and continue updating it in-place. The GC is the real concern here.
Also, found a bug that was revealed by the dispatcher removal changes in the router: One of the tests sends a raw payload with no SCION/UDP header but was crafting messages that indicated a SCION/UDP header. Since the dispatcher removal PR, the router snoops in L4 and mistakes the payload for a UDP header. That is invisible unless the payload is empty.\ No idea why the test doesn't break in master but it brakes in this PR.
We pay the GC price...until my next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stemmed from an effort at reducing the cost of ResolveLocal, which comes mostly from the net.UDPAddr API causing lots of garbage to collect. In the end that change is a bit viral and many more less costly uses were removed as well.