Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Sphinx 4.1 breaks the banner's logo #14396

Closed
tupui opened this issue Jul 12, 2021 · 1 comment · Fixed by #14397
Closed

BUG: Sphinx 4.1 breaks the banner's logo #14396

tupui opened this issue Jul 12, 2021 · 1 comment · Fixed by #14397
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Milestone
1.7.1

Comments

@tupui
Copy link
Member

tupui commented Jul 12, 2021 •
edited

Sphinx 4.1 was released on July 11th, 2021. Since then the logo file is not present anymore in the artifact which is uploaded. As we did not touch anything (I checked pipelines before and after to confirm this), I am confident this is linked to Sphinx release.

[EDIT: the path is indeed changed to /_static/_static/scipyshiny_small.png due to a Sphinx regression, see the linked Sphinx PR below.]

From the logs

# working
Running Sphinx v4.0.3
SciPy (VERSION 1.8.0.dev0+1419.1d97b81)

# failing
Running Sphinx v4.1.0
SciPy (VERSION 1.8.0.dev0+1420.0a95709)
@tupui tupui added defect A clear bug or issue that prevents SciPy from being installed or used as expected Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Jul 12, 2021
@tupui tupui added this to the 1.7.1 milestone Jul 12, 2021
This was referenced Jul 12, 2021
Merged
Merged
Merged
@ViktorHaag
Copy link

Issue created upstream in Sphinx project: sphinx-doc/sphinx#9438

rgommers pushed a commit that referenced this issue Jul 13, 2021
@tupui
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (#14397)
500878e 
[skip azp] [skip actions]

Closes gh-14396
@rgommers rgommers added backport-candidate This fix should be ported by a maintainer to previous SciPy versions. and removed backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Jul 13, 2021
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this issue Jul 23, 2021
@tupui @tylerjereddy
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
8c1b84a 
[skip azp] [skip actions]

Closes scipygh-14396
ragibson pushed a commit to ragibson/scipy that referenced this issue Jul 25, 2021
@tupui @ragibson
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
c985e0c 
[skip azp] [skip actions]

Closes scipygh-14396
Smit-create pushed a commit to Smit-create/scipy that referenced this issue Aug 27, 2021
@tupui @Smit-create
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
59abf3e 
[skip azp] [skip actions]

Closes scipygh-14396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Projects
None yet
Milestone
1.7.1
Development

Successfully merging a pull request may close this issue.

DOC/CI: do not allow sphinx 4.1. tupui/scipy
3 participants
@rgommers @ViktorHaag @tupui