Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC/CI: do not allow sphinx 4.1. #14397

Merged
merged 2 commits into from Jul 13, 2021
Merged

DOC/CI: do not allow sphinx 4.1. #14397

merged 2 commits into from Jul 13, 2021

Conversation

tupui
Copy link
Member

@tupui tupui commented Jul 12, 2021 •
edited

Closes #14396

This would mitigate the regression introduced by this new version by not allowing it...

[skip azp] [skip actions]

@tupui
DOC/CI: do not allow sphinx 4.1.
e96078c 
[skip azp] [skip actions]
@tupui tupui added defect A clear bug or issue that prevents SciPy from being installed or used as expected Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Jul 12, 2021
@tupui tupui marked this pull request as ready for review July 12, 2021 21:56
@tupui tupui requested a review from rgommers as a code owner July 12, 2021 21:56
@rgommers
Copy link
Member

Is the fix already merged? If not, Sphinx 4.1.1 will break things again if you use != 4.1.0

@tupui
Copy link
Member Author

tupui commented Jul 13, 2021

Is the fix already merged? If not, Sphinx 4.1.1 will break things again if you use != 4.1.0

Not yet, it's indeed a wishful thinking. The PR to fix the issue is sphinx-doc/sphinx#9440. Shall we instead just pin to 4.0.3 in the meantime?

@rgommers
Copy link
Member

Shall we instead just pin to 4.0.3 in the meantime?

I'd use <4.1.0

@tupui
DOC/CI: only allow sphinx <4.1.
38db0f3 
[skip azp] [skip actions]
rgommers
rgommers approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tupui!

@rgommers rgommers merged commit 500878e into scipy:master Jul 13, 2021
@rgommers rgommers added this to the 1.8.0 milestone Jul 13, 2021
@tupui tupui deleted the sphinx_version branch July 13, 2021 08:34
@rgommers rgommers added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jul 13, 2021
@tupui
Copy link
Member Author

tupui commented Jul 13, 2021 •
edited

I am testing the proposed fix upstream and will update the dependency restriction once fixed in main.

@tupui tupui mentioned this pull request Jul 15, 2021
Merged
@tylerjereddy tylerjereddy modified the milestones: 1.8.0, 1.7.1 Jul 23, 2021
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Jul 23, 2021
@tupui @tylerjereddy
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
8c1b84a 
[skip azp] [skip actions]

Closes scipygh-14396
@tylerjereddy tylerjereddy mentioned this pull request Jul 23, 2021
Merged
ragibson pushed a commit to ragibson/scipy that referenced this pull request Jul 25, 2021
@tupui @ragibson
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
c985e0c 
[skip azp] [skip actions]

Closes scipygh-14396
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jul 27, 2021
Smit-create pushed a commit to Smit-create/scipy that referenced this pull request Aug 27, 2021
@tupui @Smit-create
DOC/CI: pin sphinx to <4.1.0 to avoid logo going missing (scipy#14397)
59abf3e 
[skip azp] [skip actions]

Closes scipygh-14396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.

BUG: Sphinx 4.1 breaks the banner's logo
3 participants
@tupui @rgommers @tylerjereddy