Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: 1.7.1 backports (round 1) #14466

Merged

Conversation

tylerjereddy
Copy link
Contributor

@tylerjereddy tylerjereddy commented Jul 23, 2021

V0lantis and others added 13 commits July 23, 2021 14:57
* DEV: Update Boschloo Exact test

Update Boschloo Exact test to improve its robustness for small
numerical errors

* DOC: Update Boschloo's hypothesis doc

* DEV: Update Boschloo for small num errors
Closes scipy#14271

Resolves a rare issue when None is returned instead of a string.
Returns 'None' since that's what the old "numpy.compat.asstr"
implementation returned.
The point 2.1, 2.9 is equidistant from points 2, 2 and 3, 3 making the
k-neighbours query sensitive to the exact tree structure.
[skip azp] [skip actions]
@tylerjereddy tylerjereddy added the maintenance Items related to regular maintenance tasks label Jul 23, 2021
@tylerjereddy tylerjereddy added this to the 1.7.1 milestone Jul 23, 2021
@rgommers
Copy link
Member

The refguide check failure is a minor thing in skewtest, but would be good to fix up.

Don't have immediate plans to release it--not sure if we're on the precipice of substantial changes for i.e., pythran version or something like that just yet.

Makes sense. There's no urgent need for a release I think. The Pythran-related issue I'd like to do something about is gh-14420, but it's not fixed yet.

Also, I marked the macOS arm64 issues for 1.7.1. I got an M1 macbook a few days ago, so I should be able to do something about those more easily now.

ev-br and others added 2 commits July 25, 2021 17:24
* BUG: fix refguide-check namedtuple handling

Handle scipy.stats namedtyple *Result type classes, e.g.
`ConfidenceInterval(low=0.9950085825848624, high=0.9971212407917498)`
which can show up in both expected and actual doctest output.

Here "handle" means convert these into tuples of numeric values
and compare those.

* MAINT: refguide-check: address reviewer comments
@tylerjereddy
Copy link
Contributor Author

Updated with a backport of Evgeni's refguide fix for skewtest et al.

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy now, merging. Thanks Tyler

@rgommers rgommers merged commit f53b39c into scipy:maintenance/1.7.x Jul 27, 2021
@tylerjereddy tylerjereddy deleted the treddy_171_backports_rd1 branch July 27, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants