Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: stats.fit: fix random state #17032

Merged
merged 1 commit into from
Sep 16, 2022
Merged

TST: stats.fit: fix random state #17032

merged 1 commit into from
Sep 16, 2022

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Sep 16, 2022

Reference issue

closes gh-17031

What does this implement/fix?

The random state wasn't fixed in scipy.stats.tests.test_fit::TestFitResult::test_plot_iv, and a harmless overflow in differential_evolution (setting scale near zero, it looks like) was intermittently causing the test to fail. This fixes the random state of the test to one for which the overflow does not occur.

@mdhaber mdhaber added defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.stats labels Sep 16, 2022
@mdhaber
Copy link
Contributor Author

mdhaber commented Sep 16, 2022

Failures unrelated: prerelease failures are those mentioned in gh-17033. The Linux Meson and macOS failures have been happening for a while.

Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdhaber

@tupui tupui merged commit 8432c19 into scipy:main Sep 16, 2022
@tupui tupui added this to the 1.10.0 milestone Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: stats: Intermittent failure of the test 'test_plot_iv'
2 participants